Implement Hermite normal form and associated methods #44

frostburn · 2024-06-30T13:02:05Z

frostburn · 2024-07-01T17:42:26Z

Seems OK, but let's see that this is enough to add temperaments to sonic-weave first.

frostburn · 2024-07-03T10:20:40Z

src/basis.ts

+  commas: Monzo[],
+  commaOrthoDuals?: Monzo[]
+) {
+  return sub(monzo, nearestPlane(monzo, commas, commaOrthoDuals));


Saves a sub if the body is swapped with nearestPlane.

frostburn · 2024-07-03T10:25:30Z

src/basis.ts

+  A: number[][],
+  b: number[] | number[][]
+): typeof b {
+  const hasMultiple = Array.isArray(b[0]);


The implementation is a bit messy. Just promote the vector to a matrix.

ref #43

frostburn force-pushed the hnf branch 2 times, most recently from 2a00921 to 9ccfc8d Compare June 30, 2024 15:46

frostburn commented Jul 3, 2024

View reviewed changes

Implement Hermite normal form and associated methods

a7bc711

ref #43

frostburn force-pushed the hnf branch from 9ccfc8d to a7bc711 Compare July 3, 2024 10:49

frostburn merged commit 0eeaeb2 into main Jul 3, 2024
1 check passed

frostburn deleted the hnf branch July 3, 2024 10:55

Provide feedback